fix: wrap RequestPermissionResponse in outcome object#147
Open
chenjian-agent wants to merge 1 commit intoopenabdev:mainfrom
Open
fix: wrap RequestPermissionResponse in outcome object#147chenjian-agent wants to merge 1 commit intoopenabdev:mainfrom
chenjian-agent wants to merge 1 commit intoopenabdev:mainfrom
Conversation
masami-agent
approved these changes
Apr 9, 2026
masami-agent
left a comment
masami-agent
left a comment
There was a problem hiding this comment.
LGTM — minimal, spec-compliant fix. Wraps the RequestPermissionResponse in the required outcome envelope per ACP schema. No logic changes, backward-compatible with Kiro CLI's loose parsing.
Fixes #130.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #130: The auto-reply for session/request_permission was sending an incorrect response shape. This change wraps the outcome in the correct JSON structure as per ACP spec.