fix: wrap permission auto-reply in outcome object and select optionId dynamically

[DrVictorChen]

Summary

Combined fix for #130 and #111 — both touch the same auto-reply block in connection.rs.

• Bug: RequestPermissionResponse missing outcome wrapper — Claude Code tool calls universally rejected #130: Response was missing the required outcome wrapper. Agents that validate the ACP spec (Claude Code, Cursor) treated every tool call as rejected.
• fix: ExitPlanMode permission rejected — auto-reply sends invalid optionId #111: optionId was hardcoded to "allow_always", which is a kind, not an optionId. Different agents use different ids (e.g. Cursor uses "allow-always" with a hyphen; ExitPlanMode uses "bypassPermissions"). Unknown id → rejected → agent stuck.

Changes

1. Select the most permissive option from the request's options array by kind priority: allow_always > allow_once > first non-reject_once
2. Wrap the response in { outcome: { outcome: "selected", optionId } } per the ACP spec

Tested with

Agent	Before	After
Claude Code (ACP)	❌ all tool calls rejected	✅
Cursor agent (ACP)	❌ Cannot read properties of undefined (reading 'outcome')	✅
Codex (ACP)	✅ (was working due to loose parsing)	✅

Fixes #130, fixes #111

🤖 Generated with Claude Code

[the3mi]

PR Review ✅

Thanks @DrVictorChen for the comprehensive PR description — the What/Why/Impact table makes this easy to review.

Looks good

• Logic: Priority chain → → first non- is correct and matches the stated intent.
• Safety: fallback is safe for all edge cases (missing , missing field, not a string).
• Async lock: is held only for the minimal duration of — correct.
• ACP spec compliance: matches the ACP schema.
• Fixes both issues: This single PR resolves Bug: RequestPermissionResponse missing outcome wrapper — Claude Code tool calls universally rejected #130 (missing outcome wrapper) and fix: ExitPlanMode permission rejected — auto-reply sends invalid optionId #111 (hardcoded optionId), which is better than fix: select optionId dynamically from permission options (#111) #141's partial fix.

Minor note

If an option object exists but has no field, falls back to — this is conservative and correct.

Approve. Ready to merge.

[masami-agent]

Thanks for the combined fix! Since we're merging #147 first for the outcome wrapper, could you rebase on top of that and keep this PR scoped to just the dynamic optionId selection logic for #111? That way each PR stays single-responsibility and easier to review/revert independently.

[DrVictorChen]

Sure, will rebase once #147 is merged. Thanks for the review!