ci(nightly): harden kiro etag, cursor resolver, no-cache comment - #1522
Merged
Conversation
Follow-up to #1519 addressing review findings from Sol and Fable: - F1: accept multipart S3 ETags (<md5>-<partcount>) in the Kiro latest-object validation. The ~586MB object sits at the multipart boundary; a future re-upload flipping its ETag to the suffixed form would otherwise hard-fail every nightly-kiro build with no SHA fallback. If-Match accepts multipart ETags, so both shapes are valid. - #2: use `grep -m1` instead of `grep | head -1` in the cursor resolver to avoid the SIGPIPE (exit 141) that head-closing-the-pipe triggers under pipefail, which surfaced as a spurious red job. - F5: correct the misleading no-cache comment — no-cache rebuilds every Dockerfile.package layer for the variant, not just the CLI layer; the openab binary is not recompiled (prebuilt via the bins= context).
chaodu-agent
force-pushed
the
fix/nightly-kiro-etag-multipart
branch
from
September 3, 2026 18:34
434803f to
23a9e94
Compare
thepagent
approved these changes
Sep 3, 2026
thepagent
enabled auto-merge (squash)
September 3, 2026 18:35
thepagent
disabled auto-merge
September 3, 2026 18:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1519 addressing review findings from the two-reviewer pass (Sol, Fable) that landed after merge.
Findings addressed
latest-object ETag validation now accepts multipart ETags (<md5>-<partcount>), not only single-part 32-hex. The ~586MB object sits at the S3 multipart boundary; a future re-upload flipping its ETag to the suffixed form would otherwise hard-fail every nightly-kiro build with no SHA fallback.If-Matchaccepts multipart ETags, so both shapes are valid preconditions.grep -m1instead ofgrep … | head -1, avoiding the SIGPIPE (exit 141) that head-closing-the-pipe triggers underpipefailand which surfaced as a spurious red job.no-cache: truecomment —no-cacherebuilds everyDockerfile.packagelayer for the variant (base image, apt/node, CLI install), not just the CLI layer. Theopenabbinary is not recompiled (prebuilt via thebins=build context).Optional nits from the review (check_ver leading-dash guard, npm
--retry-all-errors, immutable-tag pre-existence check, docs for the two tag families) are intentionally not in this PR to keep it minimal; they can follow separately.Tested
python3 -c "import yaml; yaml.safe_load(...)"→ YAML parses.grep -oE -m1 … | sed …extracts the first cursor version and exits 0 underset -o pipefail(no exit 141), locally reproducing the SIGPIPE-avoidance.Blocked / not verified
mainand GHCR push); changes are confined to the resolve/build steps and validated by YAML parse + local shell repro.Review Contract
Acceptance criteria
^[0-9a-f]{32}$and^[0-9a-f]{32}-[0-9]+$.headin a pipe; first-match extraction preserved.no-cachecomment accurately describes what is rebuilt.v*) or pre-beta build paths; parity check unaffected.Out of scope (non-blocking follow-ups): check_ver leading-dash guard, npm retry-all-errors, immutable-tag pre-existence check, tag-family docs.
Stopping rule: default three-stage (full review → fix verification → final regression check).