Skip to content

Conversation

@bytes-commerce
Copy link

@bytes-commerce bytes-commerce commented Nov 15, 2024

What:

  • Bug Fix
  • New Feature

Description:

Allow list pages to be queried

Related:

#500

Change signature to accept parameters for list calls.
Adapt Interface accordingly
@bytes-commerce bytes-commerce changed the title Bytes commerce patch 1 Allow Files List to be paged Nov 15, 2024
Copy link
Collaborator

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unforunately the CI is failing with this.

PHP Fatal error: Declaration of OpenAI\Testing\Resources\FilesTestResource::list(): OpenAI\Responses\Files\ListResponse must be compatible with OpenAI\Contracts\Resources\FilesContract::list(array $parameters = []): OpenAI\Responses\Files\ListResponse in /home/runner/work/client/client/src/Testing/Resources/FilesTestResource.php on line 22

I'll take another look when pipeline fixed. Thanks for pr!

@iBotPeaches iBotPeaches marked this pull request as draft April 8, 2025 23:48
@bytes-commerce
Copy link
Author

No, thanks, I'll just close it and leave that work open for somebody else. :)

@iBotPeaches
Copy link
Collaborator

Okay. I understand it was probably due to the many month delay to review it - apologies for that.

@bytes-commerce
Copy link
Author

No bad feelings here, just the lack of time to work on it, I saw that @efpapado took on the matter which is absolutely legit, thanks for taking the care. 🌹

@bytes-commerce bytes-commerce deleted the bytes-commerce-patch-1 branch April 15, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants