Responses\CreateResponseType optional values are not handled properly #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efinition to reflect the object properties. This should surface the issues in the from() method implementation
…ature, and topP truly optional in CreateResponseType
iBotPeaches
reviewed
Jan 8, 2026
Collaborator
iBotPeaches
left a comment
iBotPeaches
left a comment
There was a problem hiding this comment.
Could you apply the same patch to the Retrieve method? Its an odd amount of duplication that I never cleaned up
https://github.com/openai-php/client/blob/main/src/Responses/Responses/RetrieveResponse.php
…pe definition and make it mirror CreateRsponse again.
Contributor
Author
|
I've consolidated the two classes, i think there was another error where a specific tool was missing. |
bbrala
commented
Jan 10, 2026
bbrala
commented
Jan 10, 2026
iBotPeaches
approved these changes
Jan 12, 2026
Collaborator
iBotPeaches
left a comment
iBotPeaches
left a comment
There was a problem hiding this comment.
thanks and good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
When using LiteLLM to proxy requests i got a few errors while building the request. It seems a few of the nullable attributes are not handled properly. This means if they are missing the package crashed.
I'm fixing this in 2 commits. First off, adjust the array shape definition to make sure the properties are optoinal, this surfaces the errors in the
frommethod. Which i will then properly handle.Related: