Skip to content

Conversation

@jiwon-oai
Copy link
Collaborator

Have simple_to_agent_input handle HiddenContextItems with str content so that simple use cases (like the cat lounge demo) don't have to implement ThreadItemConverter just to pass through item.content w/o any meaningful transformation.

@jiwon-oai jiwon-oai force-pushed the add-default-hidden-context-converter branch from 1a6d498 to bf29372 Compare November 20, 2025 23:57
Comment on lines +702 to +703
f"<HiddenContext>\n{item.content}\n</HiddenContext>"
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm maybe this should just drop the auto-tags? Saw that we were doing that with <Task> in the default converter so added it here..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... mostly I wanted to get away from being too opinionated about prompt engineering, but since these are all overridable (and should probably be overwritten in even a medium complexity integration), I think maybe it's fine to have some reasonable opinions here.

Comment on lines +702 to +703
f"<HiddenContext>\n{item.content}\n</HiddenContext>"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... mostly I wanted to get away from being too opinionated about prompt engineering, but since these are all overridable (and should probably be overwritten in even a medium complexity integration), I think maybe it's fine to have some reasonable opinions here.

@jiwon-oai jiwon-oai added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit 7ce1669 Nov 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants