Revert "rename none personality to disabled"

aibrahim-oai · aibrahim-oai · commit 6e243cc1a938 · 2026-02-04T15:20:17.000-08:00
This reverts commit 8262b88.
diff --git a/codex-rs/app-server-protocol/schema/json/ClientRequest.json b/codex-rs/app-server-protocol/schema/json/ClientRequest.json
@@ -1171,7 +1171,7 @@
     },
     "Personality": {
       "enum": [
-        "disabled",
+        "none",
         "friendly",
         "pragmatic"
       ],
diff --git a/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json b/codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json
@@ -12120,7 +12120,7 @@
       },
       "Personality": {
         "enum": [
-          "disabled",
+          "none",
           "friendly",
           "pragmatic"
         ],
diff --git a/codex-rs/app-server-protocol/schema/json/v2/ThreadResumeParams.json b/codex-rs/app-server-protocol/schema/json/v2/ThreadResumeParams.json
@@ -251,7 +251,7 @@
     },
     "Personality": {
       "enum": [
-        "disabled",
+        "none",
         "friendly",
         "pragmatic"
       ],
diff --git a/codex-rs/app-server-protocol/schema/json/v2/ThreadStartParams.json b/codex-rs/app-server-protocol/schema/json/v2/ThreadStartParams.json
@@ -29,7 +29,7 @@
     },
     "Personality": {
       "enum": [
-        "disabled",
+        "none",
         "friendly",
         "pragmatic"
       ],
diff --git a/codex-rs/app-server-protocol/schema/json/v2/TurnStartParams.json b/codex-rs/app-server-protocol/schema/json/v2/TurnStartParams.json
@@ -66,7 +66,7 @@
     },
     "Personality": {
       "enum": [
-        "disabled",
+        "none",
         "friendly",
         "pragmatic"
       ],
diff --git a/codex-rs/app-server-protocol/schema/typescript/Personality.ts b/codex-rs/app-server-protocol/schema/typescript/Personality.ts
@@ -2,4 +2,4 @@
 
 // This file was generated by [ts-rs](https://github.com/Aleph-Alpha/ts-rs). Do not edit this file manually.
 
-export type Personality = "disabled" | "friendly" | "pragmatic";
+export type Personality = "none" | "friendly" | "pragmatic";
diff --git a/codex-rs/app-server/README.md b/codex-rs/app-server/README.md
@@ -147,7 +147,7 @@ Start a fresh thread when you need a new Codex conversation.
 { "method": "thread/started", "params": { "thread": { … } } }
 ```
 
-Valid `personality` values are `"friendly"`, `"pragmatic"`, and `"disabled"`. When `"disabled"` is selected, the personality placeholder is replaced with an empty string.
+Valid `personality` values are `"friendly"`, `"pragmatic"`, and `"none"`. When `"none"` is selected, the personality placeholder is replaced with an empty string.
 
 To continue a stored session, call `thread/resume` with the `thread.id` you previously recorded. The response shape matches `thread/start`, and no additional notifications are emitted. You can also pass the same configuration overrides supported by `thread/start`, such as `personality`:
 
diff --git a/codex-rs/core/config.schema.json b/codex-rs/core/config.schema.json
@@ -708,7 +708,7 @@
     },
     "Personality": {
       "enum": [
-        "disabled",
+        "none",
         "friendly",
         "pragmatic"
       ],
diff --git a/codex-rs/core/tests/suite/personality.rs b/codex-rs/core/tests/suite/personality.rs
@@ -182,7 +182,7 @@ async fn config_personality_none_sends_no_personality() -> anyhow::Result<()> {
         .with_config(|config| {
             config.features.disable(Feature::RemoteModels);
             config.features.enable(Feature::Personality);
-            config.personality = Some(Personality::Disabled);
+            config.personality = Some(Personality::None);
         });
     let test = builder.build(&server).await?;
 
diff --git a/codex-rs/docs/codex_mcp_interface.md b/codex-rs/docs/codex_mcp_interface.md
@@ -73,7 +73,7 @@ Send input to the active turn:
 - `sendUserMessage` → enqueue items to the conversation
 - `sendUserTurn` → structured turn with explicit `cwd`, `approvalPolicy`, `sandboxPolicy`, `model`, optional `effort`, `summary`, optional `personality`, and optional `outputSchema` (JSON Schema for the final assistant message)
 
-Valid `personality` values are `friendly`, `pragmatic`, and `disabled`. When `disabled` is selected, the personality placeholder is replaced with an empty string.
+Valid `personality` values are `friendly`, `pragmatic`, and `none`. When `none` is selected, the personality placeholder is replaced with an empty string.
 
 For v2 threads, `turn/start` also accepts `outputSchema` to constrain the final assistant message for that turn.
 
diff --git a/codex-rs/docs/protocol_v1.md b/codex-rs/docs/protocol_v1.md
@@ -73,7 +73,7 @@ For complete documentation of the `Op` and `EventMsg` variants, refer to [protoc
   - `Op::ListSkills` – Request skills for one or more cwd values (optionally `force_reload`)
   - `Op::UserTurn` and `Op::OverrideTurnContext` accept an optional `personality` override that updates the model’s communication style
 
-Valid `personality` values are `friendly`, `pragmatic`, and `disabled`. When `disabled` is selected, the personality placeholder is replaced with an empty string.
+Valid `personality` values are `friendly`, `pragmatic`, and `none`. When `none` is selected, the personality placeholder is replaced with an empty string.
 
 - `EventMsg`
   - `EventMsg::AgentMessage` – Messages from the `Model`
diff --git a/codex-rs/protocol/src/config_types.rs b/codex-rs/protocol/src/config_types.rs
@@ -96,7 +96,7 @@ pub enum WindowsSandboxLevel {
 #[serde(rename_all = "lowercase")]
 #[strum(serialize_all = "lowercase")]
 pub enum Personality {
-    Disabled,
+    None,
     Friendly,
     Pragmatic,
 }
diff --git a/codex-rs/protocol/src/openai_models.rs b/codex-rs/protocol/src/openai_models.rs
@@ -335,7 +335,7 @@ impl ModelInstructionsVariables {
     pub fn get_personality_message(&self, personality: Option<Personality>) -> Option<String> {
         if let Some(personality) = personality {
             match personality {
-                Personality::Disabled => Some(String::new()),
+                Personality::None => Some(String::new()),
                 Personality::Friendly => self.personality_friendly.clone(),
                 Personality::Pragmatic => self.personality_pragmatic.clone(),
             }
@@ -548,7 +548,7 @@ mod tests {
             "Hello\n"
         );
         assert_eq!(
-            model.get_model_instructions(Some(Personality::Disabled)),
+            model.get_model_instructions(Some(Personality::None)),
             "Hello\n"
         );
         assert_eq!(model.get_model_instructions(None), "Hello\n");
@@ -570,7 +570,7 @@ mod tests {
             "Hello\n"
         );
         assert_eq!(
-            model_no_personality.get_model_instructions(Some(Personality::Disabled)),
+            model_no_personality.get_model_instructions(Some(Personality::None)),
             "Hello\n"
         );
         assert_eq!(model_no_personality.get_model_instructions(None), "Hello\n");
@@ -593,7 +593,7 @@ mod tests {
     }
 
     #[test]
-    fn get_personality_message_returns_default_when_personality_is_disabled() {
+    fn get_personality_message_returns_default_when_personality_is_none() {
         let personality_template = personality_variables();
         assert_eq!(
             personality_template.get_personality_message(None),
@@ -613,7 +613,7 @@ mod tests {
             Some("pragmatic".to_string())
         );
         assert_eq!(
-            personality_variables.get_personality_message(Some(Personality::Disabled)),
+            personality_variables.get_personality_message(Some(Personality::None)),
             Some(String::new())
         );
         assert_eq!(
@@ -635,7 +635,7 @@ mod tests {
             None
         );
         assert_eq!(
-            personality_variables.get_personality_message(Some(Personality::Disabled)),
+            personality_variables.get_personality_message(Some(Personality::None)),
             Some(String::new())
         );
         assert_eq!(
@@ -657,7 +657,7 @@ mod tests {
             Some("pragmatic".to_string())
         );
         assert_eq!(
-            personality_variables.get_personality_message(Some(Personality::Disabled)),
+            personality_variables.get_personality_message(Some(Personality::None)),
             Some(String::new())
         );
         assert_eq!(personality_variables.get_personality_message(None), None);
diff --git a/codex-rs/tui/src/app.rs b/codex-rs/tui/src/app.rs
@@ -2326,7 +2326,7 @@ impl App {
 
     fn personality_label(personality: Personality) -> &'static str {
         match personality {
-            Personality::Disabled => "Disabled",
+            Personality::None => "None",
             Personality::Friendly => "Friendly",
             Personality::Pragmatic => "Pragmatic",
         }
diff --git a/codex-rs/tui/src/chatwidget.rs b/codex-rs/tui/src/chatwidget.rs
@@ -5505,15 +5505,15 @@ impl ChatWidget {
 
     fn personality_label(personality: Personality) -> &'static str {
         match personality {
-            Personality::Disabled => "Disabled",
+            Personality::None => "None",
             Personality::Friendly => "Friendly",
             Personality::Pragmatic => "Pragmatic",
         }
     }
 
     fn personality_description(personality: Personality) -> &'static str {
         match personality {
-            Personality::Disabled => "No personality instructions.",
+            Personality::None => "No personality instructions.",
             Personality::Friendly => "Warm, collaborative, and helpful.",
             Personality::Pragmatic => "Concise, task-focused, and direct.",
         }

Original file line number	Diff line number	Diff line change
`@@ -2,4 +2,4 @@`
`2`	`2`
`3`	`3`	`// This file was generated by [ts-rs](https://github.com/Aleph-Alpha/ts-rs). Do not edit this file manually.`
`4`	`4`
`5`		`-export type Personality = "disabled" \| "friendly" \| "pragmatic";`
	`5`	`+export type Personality = "none" \| "friendly" \| "pragmatic";`