Python SDK treats model/verification and guardianWarning app-server notifications as UnknownNotification

[chanwooyang1]

What issue are you seeing?

The Python app-server SDK treats two typed v2 app-server notifications as UnknownNotification:

• model/verification
• guardianWarning

These notifications are defined and emitted by the Rust app-server protocol. The JSON/TypeScript schema also includes both variants.

However, the generated Python SDK currently does not expose ModelVerificationNotification or GuardianWarningNotification in generated/v2_all.py, and generated/notification_registry.py has no entries for either method. As a result, AppServerClient._coerce_notification() falls back to UnknownNotification.

This can cause Python SDK clients to miss typed handling for safety/account verification or guardian warning notifications.

What steps can reproduce the bug?

From the repo root:

PYTHONPATH=sdk/python/src python3 - <<'PY'
from codex_app_server.client import AppServerClient
from codex_app_server.models import UnknownNotification

client = object.__new__(AppServerClient)

notif = client._coerce_notification(
    "model/verification",
    {"threadId": "t", "turnId": "u", "verifications": ["trustedAccessForCyber"]},
)
print(type(notif.payload).__name__, isinstance(notif.payload, UnknownNotification))

warning = client._coerce_notification(
    "guardianWarning",
    {"threadId": "t", "message": "m"},
)
print(type(warning.payload).__name__, isinstance(warning.payload, UnknownNotification))
PY

Actual output:

UnknownNotification True
UnknownNotification True

What is the expected behavior?

The Python SDK should expose typed payload models for both notifications and register them in NOTIFICATION_MODELS:

• model/verification -> ModelVerificationNotification
• guardianWarning -> GuardianWarningNotification

Then _coerce_notification() should return typed notification payloads instead of UnknownNotification.

Additional information

Relevant files:

• codex-rs/app-server-protocol/src/protocol/common.rs
• codex-rs/app-server-protocol/src/protocol/v2.rs
• codex-rs/app-server/src/bespoke_event_handling.rs
• codex-rs/app-server-protocol/schema/json/ServerNotification.json
• codex-rs/app-server-protocol/schema/typescript/ServerNotification.ts
• sdk/python/src/codex_app_server/generated/v2_all.py
• sdk/python/src/codex_app_server/generated/notification_registry.py
• sdk/python/src/codex_app_server/client.py
• sdk/python/scripts/update_sdk_artifacts.py

I checked for existing issues/PRs and did not find an exact duplicate.

Related but not duplicate:

• Add safety check notification and error handling #19055 appears to add the Rust/app-server/schema side of the safety notification handling, but does not update the generated Python SDK classes or notification registry.
• Refresh generated Python app-server SDK types #18862 refreshed generated Python app-server SDK types before Add safety check notification and error handling #19055 merged, so it likely predates these notification additions.

A narrow fix could update the Python SDK generation path so these notification payload models are generated and registered, plus add a small Python SDK regression test for _coerce_notification().

If maintainers agree this is the right scope and invite a PR, I’d be happy to prepare a focused fix.

[Jerry2003826]

I prepared a focused fix for this and pushed it here:

https://github.com/Jerry2003826/codex/tree/codex/fix-python-sdk-notification-types

Summary:

• regenerate Python app-server SDK v2 artifacts so model/verification and guardianWarning payload models are exposed
• register both notifications in NOTIFICATION_MODELS
• add regression coverage for typed notification coercion
• keep the public API generation output stable with the refreshed schema

Validation run locally from sdk/python:

• uv run pytest tests/test_client_rpc_methods.py -q
• uv run pytest tests/test_public_api_signatures.py -q
• uv run pytest tests/test_public_api_runtime_behavior.py -q
• uv run pytest tests/test_async_client_behavior.py tests/test_client_rpc_methods.py tests/test_public_api_signatures.py -q
• uv run --extra dev pytest tests/test_contract_generation.py -q
• targeted ruff check / ruff format --check

I attempted to open a draft PR, but GitHub returned: Jerry2003826 does not have the correct permissions to execute CreatePullRequest. If external PRs are enabled later, I can open the PR from that branch.

[chanwooyang1]

I prepared a focused fix for this and pushed it here:

https://github.com/Jerry2003826/codex/tree/codex/fix-python-sdk-notification-types

Summary:

• regenerate Python app-server SDK v2 artifacts so model/verification and guardianWarning payload models are exposed
• register both notifications in NOTIFICATION_MODELS
• add regression coverage for typed notification coercion
• keep the public API generation output stable with the refreshed schema

Validation run locally from sdk/python:

• uv run pytest tests/test_client_rpc_methods.py -q
• uv run pytest tests/test_public_api_signatures.py -q
• uv run pytest tests/test_public_api_runtime_behavior.py -q
• uv run pytest tests/test_async_client_behavior.py tests/test_client_rpc_methods.py tests/test_public_api_signatures.py -q
• uv run --extra dev pytest tests/test_contract_generation.py -q
• targeted ruff check / ruff format --check

I attempted to open a draft PR, but GitHub returned: Jerry2003826 does not have the correct permissions to execute CreatePullRequest. If external PRs are enabled later, I can open the PR from that branch.

Thanks for sharing the branch. Since this repo follows an invitation-based contribution policy, I’ll wait for the maintainers’ preferred direction. I’m also happy to help validate the fix or prepare a focused change if invited.

[chanwooyang1]

Small follow-up: this still looks reproducible from the current generated Python SDK artifacts.

The issue is that the app-server v2 schema includes model/verification and guardianWarning notifications, but the generated Python SDK does not expose typed payload models for them and does not register them in NOTIFICATION_MODELS, so they are coerced as UnknownNotification.

I’m happy to help validate a maintainer-preferred fix, or prepare a narrow PR if invited under the repo’s contribution policy.