Skip to content

core tests: migrate rmcp turns to profiles#20037

Merged
bolinfest merged 1 commit intomainfrom
pr20037
Apr 29, 2026
Merged

core tests: migrate rmcp turns to profiles#20037
bolinfest merged 1 commit intomainfrom
pr20037

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Apr 28, 2026

Summary

  • Removes SandboxPolicy from the RMCP client test suite.
  • Adds shared read-only user-turn helpers that submit PermissionProfile::read_only() plus the legacy compatibility projection required by the current Op::UserTurn shape.
  • Keeps sandbox metadata assertions intact by deriving the expected legacy sandboxPolicy value from the same read-only profile used for the turn.

Verification

  • cargo check -p codex-core --tests
  • just fmt

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

💡 Codex Review

) && !current_permission_profile
.file_system_sandbox_policy()
.can_write_path_with_cwd(cwd, cwd)
&& current_permission_profile.network_sandbox_policy()

P2 Badge Don't mark read-only current when other write roots are allowed

The read-only branch in preset_matches_current only checks whether cwd is writable, so a managed profile that can write outside cwd (for example, a custom profile with write access to /tmp/cache but not the workspace root) is incorrectly treated as read-only. This causes /permissions to show the wrong current preset and can mislead users about the session's effective write access.


let Ok(sandbox_policy) = permission_profile.to_legacy_sandbox_policy(cwd.as_path())
else {
tx.send(AppEvent::OpenWorldWritableWarningConfirmation {

P2 Badge Keep compatibility projection for Windows world-writable scans

This path now fails closed when PermissionProfile::to_legacy_sandbox_policy returns an error, but non-legacy managed profiles are expected to hit that conversion path and were previously scanned via a compatibility sandbox projection. On Windows, those profiles will now always trigger failed_scan warnings/fallback prompts even when a compatible scan policy could be derived, creating noisy false failures for valid configurations.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

bolinfest added a commit that referenced this pull request Apr 28, 2026
## Why

The migration away from `SandboxPolicy` needs new configs to start from
permissions profiles instead of deriving profiles from legacy sandbox
modes. Existing users can have empty `config.toml` files, and we should
not rewrite user-owned config files that may live in shared
repositories.

This PR introduces built-in profile names so an empty config can resolve
to a canonical `PermissionProfile`, while explicit named `[permissions]`
profiles still behave predictably.

## What changed

- Adds built-in `default_permissions` profile names:
  - `:read-only` maps to `PermissionProfile::read_only()`.
- `:workspace` maps to the workspace-write profile, including
project-root metadata carveouts.
- `:danger-no-sandbox` maps to `PermissionProfile::Disabled`, preserving
the distinction between no sandbox and a broad managed sandbox.
- Reserves the `:` prefix for built-in profiles so user-defined
`[permissions]` profiles cannot collide with future built-ins.
- Allows `default_permissions` to reference a built-in profile without
requiring a `[permissions]` table.
- Makes an otherwise empty config choose a built-in profile by
trust/platform context: trusted or untrusted project roots use
`:workspace` when the platform supports that sandbox, while roots
without a trust decision use `:read-only`.
- Keeps legacy `sandbox_mode` configs on the legacy path, and still
rejects user-defined `[permissions]` profiles that omit
`default_permissions` so we do not silently guess among custom profiles.
- Preserves compatibility behavior for implicit defaults: bare
`network.enabled = true` allows runtime network without starting the
managed proxy, explicit profile proxy policy still starts the proxy, and
implicit workspace/add-dir roots keep legacy metadata carveouts.

## Verification

- `cargo test -p codex-core builtin --lib`
- `cargo test -p codex-core profile_network_proxy_config`
- `cargo test -p codex-core
implicit_builtin_workspace_profile_preserves_add_dir_metadata_carveouts`
- `cargo test -p codex-core
permissions_profiles_network_enabled_allows_runtime_network_without_proxy`
- `cargo test -p codex-core
permissions_profiles_proxy_policy_starts_managed_network_proxy`

## Documentation

Public Codex config docs should mention these built-in names when the
`[permissions]` config format is ready to document as stable.









---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/openai/codex/pull/19900).
* #20041
* #20040
* #20037
* #20035
* #20034
* #20033
* #20032
* #20030
* #20028
* #20027
* #20026
* #20024
* #20021
* #20018
* #20016
* #20015
* #20013
* #20011
* #20010
* #20008
* __->__ #19900
@bolinfest bolinfest force-pushed the pr20037 branch 3 times, most recently from 4d28a7f to bb764dc Compare April 28, 2026 20:02
@bolinfest bolinfest force-pushed the pr20035 branch 2 times, most recently from b46b36a to d15d406 Compare April 28, 2026 20:10
@bolinfest bolinfest force-pushed the pr20037 branch 2 times, most recently from 24defbb to bc9fa21 Compare April 28, 2026 20:12
bolinfest added a commit that referenced this pull request Apr 28, 2026
## Summary
- Move TUI permission state from legacy `SandboxPolicy` values to
canonical `PermissionProfile` values across presets, app events, chat
widget state, app commands, thread routing, and cached thread session
state.
- Keep app-server compatibility boundaries explicit: embedded sessions
send `permissionProfile`, while remote sessions send only a legacy
`sandbox` projection and fall back to read-only when a custom profile
cannot be projected.
- Update status/add-dir UI summaries and snapshots to render the active
permission profile, including workspace profiles selected by the new
built-in defaults.

## Verification
- `rg '\bSandboxPolicy\b' codex-rs/tui -n` returns no matches.
- `cargo test -p codex-tui`
- `cargo check -p codex-tui --tests`
- `cargo test -p codex-tui additional_dirs`
- `just fmt`
- `just fix -p codex-tui`




































---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/openai/codex/pull/20008).
* #20041
* #20040
* #20037
* #20035
* #20034
* #20033
* #20032
* #20030
* #20028
* #20027
* #20026
* #20024
* #20021
* #20018
* #20016
* #20015
* #20013
* #20011
* #20010
* __->__ #20008
@bolinfest bolinfest requested a review from viyatb-oai April 29, 2026 00:03
bolinfest added a commit that referenced this pull request Apr 29, 2026
## Summary
- Migrate direct `Op::UserTurn` construction in remote-model tests from
legacy `SandboxPolicy::DangerFullAccess` to
`PermissionProfile::Disabled` via `turn_permission_fields()`.
- Migrate the Responses API proxy header helper from an inline
workspace-write `SandboxPolicy` to
`PermissionProfile::workspace_write()`.
- Reduce `SandboxPolicy` references in `codex-rs/core/tests` from 22
files after #20015 to 20 files.

## Testing
- `cargo check -p codex-core --tests`
- `just fmt`





























---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/openai/codex/pull/20016).
* #20041
* #20040
* #20037
* #20035
* #20034
* #20033
* #20032
* #20030
* #20028
* #20027
* #20026
* #20024
* #20021
* #20018
* __->__ #20016
Base automatically changed from pr20035 to main April 29, 2026 00:17
@bolinfest bolinfest merged commit 1dae578 into main Apr 29, 2026
13 of 14 checks passed
@bolinfest bolinfest deleted the pr20037 branch April 29, 2026 00:17
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant