core tests: migrate view image turns to profiles

[bolinfest]

Why

This stack is removing direct SandboxPolicy usage from test code so new tests exercise the same PermissionProfile path that runtime code now treats as canonical. view_image.rs still built Op::UserTurn requests with SandboxPolicy::DangerFullAccess and no permission profile, which kept another core test module on the legacy turn shape.

What Changed

• Adds a small disabled_user_turn() helper for the view-image suite that derives the compatibility sandbox_policy and canonical permission_profile from PermissionProfile::Disabled.
• Replaces repeated direct Op::UserTurn literals in codex-rs/core/tests/suite/view_image.rs with that helper.
• Removes all SandboxPolicy references from view_image.rs, reducing the remaining codex-rs/core/tests files that mention SandboxPolicy from 18 to 17.

Verification

• cargo check -p codex-core --tests

[chatgpt-codex-connector]

💡 Codex Review

codex/codex-rs/core/src/config/permissions.rs

Line 115 in 46cd0b9

config.network.enabled = false;

Preserve profile proxy enablement without cloud requirements

network_proxy_config_from_profile_network now unconditionally sets config.network.enabled = false, which makes profile-level proxy policy inert in the common path where no cloud network requirements are loaded. In that path, config assembly only keeps the proxy when network.enabled() is true, so profile settings like domain allow/deny lists or custom proxy endpoints stop being enforced even when network.enabled = true is set in the selected permissions profile, broadening runtime network access unexpectedly.

---

codex/codex-rs/core/src/config/mod.rs

Line 1898 in 46cd0b9

) || permission_config_syntax.is_none();

Keep legacy writable-root carveouts for implicit default mode

Treating permission_config_syntax == None as profile mode routes default/no-syntax configs through the profiles branch, which applies with_additional_writable_roots for extra roots instead of the legacy with_additional_legacy_workspace_writable_roots path. That drops legacy metadata carveouts (for paths like .git/.codex) on --add-dir roots in implicit default sessions, so users can get broader write access than before without opting into explicit profile syntax.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[bolinfest]

[codex] Addressed in the updated bottom commit for #19900: 13a4587. The profile network conversion now keeps the managed proxy enabled when a profile includes explicit proxy-enforced policy, while leaving it disabled for bare network access. The implicit built-in workspace profile path also now applies legacy metadata carveouts to additional writable roots, with regression coverage for add-dir roots.

[bolinfest]

[codex] Follow-up after restacking: the fixes are now in #19900 at 33482fd. I also updated the config regression tests so bare network access and explicit proxy policy are covered separately.