Add goal lifecycle metrics#20799
Merged
Merged
Conversation
etraut-openai
changed the title
jif-oai
reviewed
May 4, 2026
etraut-openai
added a commit
that referenced
this pull request
May 5, 2026
etraut-openai
force-pushed
the
etraut/goal-metrics
branch
from
2478a64 to
03f1a23
Compare
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03f1a23197
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jif-oai
approved these changes
May 5, 2026
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
This will become sketchy the day we have multi-clients but good fo rnow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Adding goal metrics makes it possible to track how often goals are created, completed, and stopped by budget limits, plus the final token and wall-clock usage for terminal outcomes.
What Changed
codex.goal.created: increments each time a new persisted goal is created or an existing goal is replaced with a new objective.codex.goal.completed: increments when a goal transitions tocomplete.codex.goal.budget_limited: increments when a goal transitions tobudget_limitedbecause its token budget has been reached.codex.goal.token_count: records the final persisted token count when a goal transitions tocompleteorbudget_limited.codex.goal.duration_s: records the final persisted elapsed wall-clock time, in seconds, when a goal transitions tocompleteorbudget_limited.completeorbudget_limited, avoiding double-counting later in-flight accounting for already budget-limited goals.codex-coretests for create/complete metrics and one-time budget-limit metrics.