Add goal lifecycle metrics#20799
Open
etraut-openai wants to merge 1 commit intomainfrom
Open
Conversation
etraut-openai
changed the title
jif-oai
reviewed
May 4, 2026
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn goal_created_and_completed_metrics_are_emitted() -> anyhow::Result<()> { |
Collaborator
There was a problem hiding this comment.
I don't think we should test this tbh
| previous_status | ||
| }; | ||
| if replacing_goal { | ||
| self.emit_goal_created_metric(); |
Collaborator
There was a problem hiding this comment.
This only fires on the Session-owned create/replace path. thread_goal_set in app-server still creates/replaces goals by writing state_db directly and then only applies runtime effects, so creating a goal from the UI on a live thread won’t increment codex.goal.created.
| if replacing_goal { | ||
| self.emit_goal_created_metric(); | ||
| } | ||
| self.emit_goal_terminal_metrics_if_status_changed(previous_status_for_goal, &goal); |
| accounting.wall_clock.clear_active_goal(); | ||
| } | ||
| } | ||
| self.emit_goal_terminal_metrics_if_status_changed(previous_status, &goal); |
Collaborator
There was a problem hiding this comment.
(found by Codex)
We can double-count one logical completion here. handle_update_goal does GoalRuntimeEvent::ToolCompletedGoal first and then set_thread_goal(...Complete). If the last tool pushes the goal over budget, this line emits budget_limited, and the subsequent completion path emits completed for the same goal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Adding goal metrics makes it possible to track how often goals are created, completed, and stopped by budget limits, plus the final token and wall-clock usage for terminal outcomes.
What Changed
codex.goal.created: increments each time a new persisted goal is created or an existing goal is replaced with a new objective.codex.goal.completed: increments when a goal transitions tocomplete.codex.goal.budget_limited: increments when a goal transitions tobudget_limitedbecause its token budget has been reached.codex.goal.token_count: records the final persisted token count when a goal transitions tocompleteorbudget_limited.codex.goal.duration_s: records the final persisted elapsed wall-clock time, in seconds, when a goal transitions tocompleteorbudget_limited.completeorbudget_limited, avoiding double-counting later in-flight accounting for already budget-limited goals.codex-coretests for create/complete metrics and one-time budget-limit metrics.