Conversation
celia-oai
changed the title
item/reasoning/delta and item/agentMessage/delta
celia-oai
changed the title
item/reasoning/delta and item/agentMessage/deltaitem/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAdded
celia-oai
changed the title
item/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAddeditem/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAdded
owenlin0
reviewed
Nov 13, 2025
celia-oai
force-pushed
the
dev/cc/add-item-2
branch
12 times, most recently
from
55c2a16 to
f26660f
Compare
celia-oai
force-pushed
the
dev/cc/add-item-2
branch
5 times, most recently
from
a0b1805 to
1cfef9d
Compare
owenlin0
approved these changes
Nov 13, 2025
| #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)] | ||
| #[serde(rename_all = "camelCase")] | ||
| #[ts(export_to = "v2/")] | ||
| pub struct ReasoningSummaryPartAddedNotification { |
Collaborator
There was a problem hiding this comment.
Do we need a ReasoningContentPartAddedNotification too? since ThreadItem has both summary and content vectors
Collaborator
Author
There was a problem hiding this comment.
reason for this is explained in this thread!
celia-oai
force-pushed
the
dev/cc/add-item-2
branch
4 times, most recently
from
b35020b to
e8c7642
Compare
celia-oai
force-pushed
the
dev/cc/add-item-2
branch
from
e8c7642 to
64f4b66
Compare
celia-oai
force-pushed
the
dev/cc/add-item-2
branch
from
e4ba191 to
03c6d30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core event to app server event mapping:
codex/event/reasoning_content_delta->item/reasoning/summaryTextDelta.codex/event/reasoning_raw_content_delta->item/reasoning/textDeltacodex/event/agent_message_content_delta→item/agentMessage/delta.codex/event/agent_reasoning_section_break->item/reasoning/summaryPartAdded.Also added a change in core to pass down content index, summary index and item id from events.
Tested with the
git checkout owen/app_server_test_client && cargo run -p codex-app-server-test-client -- send-message-v2 "hello"and verified that new events are emitted correctly.