Clarify external editor env var message #10030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibrahim-oai
approved these changes
Jan 27, 2026
joshka-oai
deleted the
codex/fix-error-message-clarity-for-editor-setting
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
VISUAL/EDITORmust be set before launching Codex, not during a running session.Description
codex-rs/tui/src/app.rsto:"Cannot open external editor: set $VISUAL or $EDITOR before starting Codex."and runjust fmtto apply formatting.Testing
just fmtsuccessfully; attemptedcargo test -p codex-tuibut it failed due to network errors when fetching git dependencies (tests did not complete).Codex Task