feat: fire tracking events for skill invocation #10120
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 753213dd4d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 780c0141f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f554cb5f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f26aba199e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8a598ed38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
codex-rs/core/src/codex.rs
Outdated
| None => None, | ||
| }; | ||
| let config = sess.get_config().await; | ||
| let tracking = TrackEventsContext { |
There was a problem hiding this comment.
Maybe move this to a helper function in analytics_client.rs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8459e6506
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub(crate) async fn build_skill_injections( | ||
| mentioned_skills: &[SkillMetadata], | ||
| otel: Option<&OtelManager>, | ||
| tracking: Option<&TrackEventsContext>, |
There was a problem hiding this comment.
ideally you inject some kind of initialized client here instead of having to carry all this context.
| const ANALYTICS_EVENTS_QUEUE_SIZE: usize = 256; | ||
| const ANALYTICS_EVENTS_TIMEOUT: Duration = Duration::from_secs(10); | ||
|
|
||
| static ANALYTICS_EVENTS_SENDER: OnceLock<mpsc::Sender<TrackEventsJob>> = OnceLock::new(); |
There was a problem hiding this comment.
can we avoid the static? check out how other clients are stored on SessionServices.
codex-rs/core/src/codex.rs
Outdated
| .await; | ||
|
|
||
| let otel_manager = turn_context.client.get_otel_manager(); | ||
| let auth = match turn_context.client.get_auth_manager() { |
There was a problem hiding this comment.
consider creating the client early (on session creation) and storing it.
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
let's have the client be the thing we store and use to emit events
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
Approved with comments.
No description provided.