Chore: plan mode do not include free form question and always include isOther

[shijie-oai]

We should never ask a freeform question when planning and we should always include isOther as an escape hatch.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8dc00a2779

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Fix example closing tag indentation

The example shows the closing </proposed_plan> tag with two leading spaces, which contradicts the immediately preceding rule that the tags must be exactly <proposed_plan> and </proposed_plan> on their own lines. Since this example is likely to be copied verbatim, it can lead the client to emit a malformed closing tag that won’t be recognized by the renderer.

Useful? React with 👍 / 👎.

[charley-oai]

Should we just delete isOther from the tool? Why expose this as a tool arg if it should always be true?

[aibrahim-oai]

[shijie-oai]

Causing rendering UI and I am too lazy to update the logic there lol

[charley-oai]

Ah but maybe we could just make the model visible tool not include isOther, but hardcode it to true when we send the toolcall to the client? Generally keeping model visible things clean is good for model quality

[shijie-oai]

ya let me do that!

[chatgpt-codex-connector]

💡 Codex Review

codex/codex-rs/core/src/skills/env_var_dependencies.rs

Lines 46 to 49 in 0b4f5bd

	match env::var(&name) {
	Ok(value) => {
	loaded_values.insert(name.clone(), value);
	continue;

Treat empty env vars as missing for skill deps

The new dependency resolver treats any present environment variable as satisfied, but env::var returns Ok("") for empty values. That means a user can have an env var set but empty (common when clearing secrets), and the code will skip prompting and store an empty value in dependency_env, so skill execution will fail later without giving the user a chance to supply the required secret. Consider treating empty/whitespace values as missing, similar to other env‑var consumers in the codebase.

---

codex/codex-rs/tui/src/lib.rs

Lines 358 to 360 in 0b4f5bd

	let log_db_layer = codex_core::state_db::get_state_db(&config, None)
	.await
	.map(|db| log_db::start(db).with_filter(env_filter()));

Log DB layer never attaches on fresh installs

The log DB layer is only created if get_state_db returns a handle, which only happens when the SQLite file already exists. On a fresh profile, the DB is created later by state_db::init_if_enabled during session startup, so this layer stays None for the entire run and no logs are persisted until the next launch. If the intent is to record the very first session, the logger needs to attach after DB creation or initialize the DB here.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[shijie-oai]

We hardcode the isOther property to true passing it to downstream consumer. isOther itself is removed from the tool spec.

[charley-oai]

Nice looks good