Add a codex.rate_limits event for websockets#10324
Merged
rasmusrygaard merged 7 commits intomainfrom Feb 4, 2026
Merged
Conversation
pakrym-oai
reviewed
Feb 1, 2026
pakrym-oai
reviewed
Feb 1, 2026
pakrym-oai
reviewed
Feb 1, 2026
pakrym-oai
requested changes
Feb 1, 2026
Collaborator
pakrym-oai
left a comment
There was a problem hiding this comment.
few comments.
I think it might be cleaner to add separate event for rate limit than we don't have to cram everything in metadata.
Also some of this information doesn't change during the connection and can be returned on websocket headers.
5d7b2c7 to
7730170
Compare
pakrym-oai
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When communicating over websockets, we can't rely on headers to deliver rate limit information. This PR adds a
codex.rate_limitsevent that the server can pass to the client to inform them about rate limit usage. The client parses this data the same way we parse rate limit headers in HTTP mode.This PR also wires up the etag and reasoning headers for websockets