fix: System skills marker includes nested folders recursively #10350
+74
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsong-oai
approved these changes
Feb 2, 2026
xl-openai
approved these changes
Feb 2, 2026
xl-openai
reviewed
Feb 2, 2026
| @@ -86,21 +86,8 @@ fn read_marker(path: &AbsolutePathBuf) -> Result<String, SystemSkillsError> { | |||
| } | |||
|
|
|||
| fn embedded_system_skills_fingerprint() -> String { | |||
Collaborator
There was a problem hiding this comment.
FYI We can also just bump SYSTEM_SKILLS_MARKER_SALT.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated system skills bundled with Codex were not correctly replacing the user's skills in their .system folder.
.codex-system-skills.markernot updating by hashing embedded system skills recursively (nested dirs + file contents), so updates trigger a reinstall.src/skills/assets/samples/*, ensuring embedded skill updates rebuild correctly under caching.