Do not append items on override turn context #10354
Merged
+288
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store CollaborationMode in TurnContext instead of ModeKind and update all callsites. Use previous TurnContext when building collaboration mode update items to avoid redundant updates.
Drop unused previous/next collaboration mode in handlers and use turn_context.collaboration_mode.mode where a ModeKind is required.
- Add helper to build collaboration mode with arbitrary ModeKind - Rename tests to reflect that overrides without a user turn do not record updates - Ensure override-only changes do not emit environment, permissions, or collaboration rollout entries - Adjust permissions message count expectations across permissions and resume tests - Add tests for collaboration mode change vs. noop when mode is unchanged - Add personality test ensuring no update message
aibrahim-oai
approved these changes
Feb 2, 2026
pakrym-oai
deleted the
pakrym/do-not-append-items-on-override-turn-context
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.