-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Added support for live updates to skills #10478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+684
−28
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
76c7486
Added support for live updates to skills
etraut-openai d594589
Fixed failing tests
etraut-openai 4cce84a
Simplified fix
etraut-openai a647a40
Merge branch 'etraut/live_skill_update_part1-1' into etraut/live_skil…
etraut-openai 9c22c7b
Undid unnecessary test change
etraut-openai 20c6f19
Another unnecessary change
etraut-openai 7a83429
Removed more unnecessary changes
etraut-openai 24087d2
Fixed failing test
etraut-openai 8a3c219
Merge branch 'main' into etraut/live_skill_update_part1
etraut-openai 22de58c
Merge branch 'main' into etraut/live_skill_update_part1
etraut-openai d73ff90
Merge remote-tracking branch 'origin/main' into live_skill_update_part1
xl-openai f870207
Remove SkillsListUpdatedNotification and Address comments.
xl-openai 66abc4f
Skip nearest_existing_ancestor
xl-openai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we will still emit EventMsg::SkillsUpdateAvailable (for each session) for app-server clients right?