Merged
Conversation
jif-oai
reviewed
Feb 4, 2026
| pub(crate) struct TurnContext { | ||
| pub(crate) sub_id: String, | ||
| pub(crate) client: ModelClient, | ||
| pub(crate) config: Arc<Config>, |
Collaborator
There was a problem hiding this comment.
Do you plan to remove all those fields from the ModelClientState then?
Collaborator
Author
There was a problem hiding this comment.
Not all, at least half but either way I don't think we should be using the client to carry them around. The fact that the client needs otel is it's implementation detail.
aibrahim-oai
reviewed
Feb 4, 2026
| pub(crate) reasoning_effort: Option<ReasoningEffortConfig>, | ||
| pub(crate) reasoning_summary: ReasoningSummaryConfig, | ||
| pub(crate) session_source: SessionSource, | ||
| pub(crate) transport_manager: TransportManager, |
Collaborator
There was a problem hiding this comment.
Shouldn't this live on client? or because it can change on websocket failure?
Collaborator
Author
There was a problem hiding this comment.
This will get merged with the client.
aibrahim-oai
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to make client session wide. This requires shedding all random state it has to carry.