Cloud Requirements: increase timeout and retries#10631
Merged
alexsong-oai merged 2 commits intomainfrom Feb 5, 2026
Merged
Conversation
jif-oai
reviewed
Feb 4, 2026
| self.fetch_with_retries(&auth).await | ||
| } | ||
|
|
||
| async fn fetch_with_retries(&self, auth: &CodexAuth) -> Option<ConfigRequirementsToml> { |
Collaborator
There was a problem hiding this comment.
We should have shared code for this kind of things that support exp backoff etc
Contributor
Author
There was a problem hiding this comment.
am depending on backoff here. I can introduce a retry crate but would argue unnecessary for a for-loop
| } | ||
| } | ||
|
|
||
| struct SequenceFetcher { |
Collaborator
There was a problem hiding this comment.
this looks like a very non idiomatic way to a retry policy
Contributor
Author
There was a problem hiding this comment.
This is just in the test, to force retries?
gt-oai
force-pushed
the
gt/more-robust-cloud-req-load
branch
4 times, most recently
from
a5b1353 to
5ddc8a4
Compare
gt-oai
force-pushed
the
gt/more-robust-cloud-req-load
branch
from
5ddc8a4 to
8014b74
Compare
alexsong-oai
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add retries and an increased-length timeout for loading Cloud Requirements.