Conversation
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 155291c737
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f7810c5c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sess.record_user_prompt_and_emit_turn_item( | ||
| turn_context.as_ref(), | ||
| &user_message.content, | ||
| response_item, | ||
| ) |
There was a problem hiding this comment.
The new path emits UserMessage items for pending input by calling record_user_prompt_and_emit_turn_item with user_message.content derived from parse_turn_item, but parse_user_message rebuilds UserInput from ContentItem and explicitly sets text_elements: Vec::new() (see codex-rs/core/src/event_mapping.rs), dropping UI-only metadata like mention spans and local image paths. This means mid-turn injected input that included mentions or local images will now emit user-message events missing those spans/paths, so the UI can no longer render highlights or local image references for the injected prompt. To preserve the intended metadata (per the comment on record_user_prompt_and_emit_turn_item), the pending input needs to retain the original UserInput rather than reconstructing it from ResponseItem.
Useful? React with 👍 / 👎.
2 participants
Uh oh!
There was an error while loading. Please reload this page.