Cache cloud requirements #11305
Merged
Cache cloud requirements #11305
+666
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gt-oai
force-pushed
the
gt/cache-cloud-reqs
branch
from
d8fe534 to
c53815f
Compare
gt-oai
force-pushed
the
gt/cache-cloud-reqs
branch
from
c53815f to
10227ae
Compare
| enum CacheLoadStatus { | ||
| #[error("Skipping cloud requirements cache read because auth identity is incomplete")] | ||
| AuthIdentityIncomplete, | ||
| #[error("cloud requirements cache file not found")] |
Contributor
There was a problem hiding this comment.
nit: first word is not capitalized in some errors and is in other error strings.
| let account_id = account_id.as_deref(); | ||
|
|
||
| self.fetch_with_retries(&auth).await | ||
| match self.load_cache(chatgpt_user_id, account_id).await { |
Contributor
There was a problem hiding this comment.
If load_cache fails, do we fallback to network fetch (with the regular retries treatment)?
Contributor
Author
There was a problem hiding this comment.
yes we fall back (line 273)
gverma-openai
approved these changes
Feb 10, 2026
gt-oai
force-pushed
the
gt/cache-cloud-reqs
branch
from
10227ae to
1d3cb36
Compare
gt-oai
force-pushed
the
gt/cache-cloud-reqs
branch
from
1d3cb36 to
b8c577e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're loading these from the web on every startup. This puts them in a local file with a 1hr TTL.
We sign the downloaded requirements with a key compiled into the Codex CLI to prevent unsophisticated tampering (determined circumvention is outside of our threat model: after all, one could just compile Codex without any of these checks).
If any of the following are true, we ignore the local cache and re-fetch from Cloud: