Do not resend output items in incremental websockets connections #11383
+364
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
changed the title
sayan-oai
reviewed
Feb 11, 2026
| .take() | ||
| .and_then(|mut receiver| match receiver.try_recv() { | ||
| Ok(last_response) => Some(last_response), | ||
| Err(TryRecvError::Closed) | Err(TryRecvError::Empty) => None, |
Collaborator
There was a problem hiding this comment.
why do we now drop the receiver on TryRecvError::Empty? if there's a follow up request before the previous stream finishes, aren't we now losing the LastResponse?
Collaborator
Author
There was a problem hiding this comment.
means previous request didn't complete with response.done and if it didn't then trying to append to it is dangerous.
sayan-oai
approved these changes
Feb 11, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the incremental websocket output items are already part of the context, no need to send them again and duplicate.