app-server: thread resume subscriptions #11474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxj-oai
force-pushed
the
maxj/threadstate
branch
from
5f1f275 to
8148704
Compare
maxj-oai
force-pushed
the
maxj/threadresume1
branch
from
fc45db4 to
9e506da
Compare
maxj-oai
force-pushed
the
maxj/threadresume1
branch
2 times, most recently
from
ad28e92 to
40a29cb
Compare
maxj-oai
force-pushed
the
maxj/threadresume1
branch
from
40a29cb to
ae124ae
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ca45ea974
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
owenlin0
reviewed
Feb 11, 2026
owenlin0
approved these changes
Feb 12, 2026
| .await | ||
| { | ||
| send_error = Some(err); | ||
| break; |
Collaborator
There was a problem hiding this comment.
is it a good idea to short-circuit or should we continue sending to the rest of the connections?
Contributor
Author
There was a problem hiding this comment.
hmm I think stopping is right - this is a single shared queue not per connection so if it's erroring no reason to continue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stack layer makes app-server thread event delivery connection-aware so resumed/attached threads only emit notifications and approval prompts to subscribed connections.
ThreadState(subscribed_connections) and mapped subscription ids to(thread_id, connection_id).connection_closed(connection_id)plumbing (lib.rs->message_processor.rs->codex_message_processor.rs) so disconnect cleanup happens immediately.TargetedOutgoingto send requests/notifications only to subscribed connections.