Pre-sampling compact with previous model context #11504
Conversation
aibrahim-oai
commented
Feb 11, 2026
aibrahim-oai
commented
- Run pre-sampling compact through a single helper that builds previous-model turn context and compacts before the follow-up request when switching to a smaller context window.
- Keep compaction events on the parent turn id and add compact suite coverage for switch-in-session and resume+switch flows.
aibrahim-oai
changed the base branch from
main
to
ab/previous-model-hydration
| // Emit completion uniformly from spawn site so all tasks share the same lifecycle. | ||
| let sess = session_ctx.clone_session(); | ||
| sess.on_task_finished(ctx_for_finish, last_agent_message) | ||
| sess.on_task_finished(Arc::clone(&ctx_for_finish), last_agent_message) |
There was a problem hiding this comment.
probably coming from the first PR. will remove
| }) | ||
| } | ||
|
|
||
| pub(crate) async fn with_model(&self, model: String, models_manager: &ModelsManager) -> Self { |
There was a problem hiding this comment.
is there a change we can highjack some of the existing context construction methods?
|
@codex review |
aibrahim-oai
force-pushed
the
compact-previous-model-context
branch
from
e9707f3 to
dace82e
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9707f3a3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aibrahim-oai
force-pushed
the
compact-previous-model-context
branch
from
30f0c79 to
0c48994
Compare
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7fdccb13f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a07f84b646
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
