fix: show user warning when using default fallback metadata#11690
Merged
fix: show user warning when using default fallback metadata#11690
Conversation
pakrym-oai
reviewed
Feb 13, 2026
pakrym-oai
reviewed
Feb 13, 2026
pakrym-oai
approved these changes
Feb 13, 2026
Collaborator
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
Looks reasonable but I think can be much simplified by moving the used_fallback to model info and not caching warnings.
sayan-oai
commented
Feb 13, 2026
| #[serde(default, skip_serializing, skip_deserializing)] | ||
| #[schemars(skip)] | ||
| #[ts(skip)] | ||
| pub used_fallback_model_metadata: bool, |
Collaborator
Author
There was a problem hiding this comment.
marked as internal only because its not actually part of model metadata; we are just using it to track local resolution state. i could make it public, though i think that's misleading, or we could go back to the wrapper struct
sayan-oai
force-pushed
the
dev/sayan/warn-on-fallback-metadata
branch
from
1fdb4fd to
045f383
Compare
aibrahim-oai
approved these changes
Feb 13, 2026
sayan-oai
force-pushed
the
dev/sayan/warn-on-fallback-metadata
branch
from
610e78a to
26b5acc
Compare
sayan-oai
force-pushed
the
dev/sayan/warn-on-fallback-metadata
branch
from
7a56b7f to
5c9119c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
It's currently unclear when the harness falls back to the default, generic
ModelInfo. This happens when theremote_modelsfeature is disabled or the model is truly unknown, and can lead to bad performance and issues in the harness.Add a user-facing warning when this happens so they are aware when their setup is broken.
Tests
Added tests, tested locally.