remove feature flag collaboration modes#12028
Conversation
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae31891d43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| stage: Stage::Removed, | ||
| default_enabled: true, |
There was a problem hiding this comment.
Setting Feature::CollaborationModes to Stage::Removed while keeping default_enabled: true breaks the invariant checked by default_enabled_features_are_stable() (same file, lines 710-719). That test requires every default-enabled feature to be Stage::Stable, so this change introduces a failing core test and blocks CI.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
- Updated
Feature::CollaborationModesto remainStage::Stablewhile stilldefault_enabled: true, so it no longer violates the default-enabled stability invariant in core feature tests. codex-rs/core/src/features.rsL599-L603 codex-rs/core/src/features.rsL710-L719 - Committed the fix on branch
work(069faa8) and created a follow-up PR message via themake_prtool.
Testing
- ✅
just fmt - ✅
cargo test -p codex-core default_enabled_features_are_stable --lib ⚠️ cargo test -p codex-core(fails in this environment due unrelated existing tests requiring loopback/network/shell behavior not available here)⚠️ cargo test --all-features(failed due environment disk exhaustion while building the full workspace tests)⚠️ curl -I https://example.com(web access attempt returned proxy403, so external web search was not available in this environment)
Allow default-enabled removed feature aliases in the core invariant test so collaboration_modes cleanup does not fail CI after rebase. Also rename an unused chatwidget parameter introduced by conflict resolution. Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
force-pushed
the
remove/collaboration/modes
branch
from
1dd6760 to
608a68d
Compare
|
@codex review |
|
Security review completed. No security issues were found in this pull request. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
All code should go in the direction that steer is enabled