Merged
Conversation
This was referenced Feb 17, 2026
f611aa7 to
92b057f
Compare
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92b057f8c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c264067 to
136bbb0
Compare
owenlin0
added a commit
that referenced
this pull request
Feb 18, 2026
zsh fork PR stack: - #12051 👈 - #12052 With upcoming support for a fork of zsh that allows us to intercept `execve` and run execpolicy checks for each subcommand as part of a `CommandExecution`, it will be possible for there to be multiple approval requests for a shell command like `/path/to/zsh -lc 'git status && rg \"TODO\" src && make test'`. To support that, this PR introduces a new `approval_id` field across core, protocol, and app-server so that we can associate approvals properly for subcommands.
136bbb0 to
8fcd498
Compare
Collaborator
|
Onward! |
bolinfest
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zsh fork PR stack:
Summary
This PR introduces a feature-gated native shell runtime path that routes shell execution through a patched zsh exec bridge, removing MCP-specific behavior from the shell hot path while preserving existing CommandExecution lifecycle semantics.
When shell_zsh_fork is enabled, shell commands run via patched zsh with per-
execveinterception through EXEC_WRAPPER. Core receives wrapper IPC requests over a Unix socket, applies existing approval policy, and returns allow/deny before the subcommand executes.What’s included
1) New zsh exec bridge runtime in core
2) Session lifecycle integration
SessionServices now owns a
ZshExecBridge.Session startup initializes bridge state; shutdown tears it down cleanly.
3) Shell runtime routing (feature-gated)
When
shell_zsh_forkis enabled:zsh_exec_bridge.execute_shell_request(...)instead of the regular shell path.4) Config + feature wiring
Feature::ShellZshFork(under development).zsh_path(optional absolute path to patched zsh):Config,ConfigToml,ConfigProfile, overrides, and schema.zsh_pathexists/usable when zsh-fork is enabled.zsh_pathfailure mode.5) Seatbelt/sandbox updates for wrapper IPC
6) Runtime entrypoint hooks
EXEC_WRAPPER.7) Tool selection behavior