Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b4e7aa7c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f4c5afa50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .into_iter() | ||
| .filter_map(|command| match command { | ||
| ParsedCommand::Read { path, .. } => get_memory_kind(path.display().to_string()), | ||
| ParsedCommand::Search { path, .. } => path.and_then(get_memory_kind), |
There was a problem hiding this comment.
ParsedCommand::Search.path is typically a short display path (e.g., MEMORY.md, skills) rather than a full path. Passing it directly to get_memory_kind means searches like rg .../memories/MEMORY.md will not match memories/... checks, so memory-search activity is silently uncounted.
Useful? React with 👍 / 👎.
1 participant
No description provided.