Skip to content

app-server: retain thread listener across disconnects#12373

Merged
maxj-oai merged 3 commits intomainfrom
maxj/retain-thread-listener
Feb 22, 2026
Merged

app-server: retain thread listener across disconnects#12373
maxj-oai merged 3 commits intomainfrom
maxj/retain-thread-listener

Conversation

@maxj-oai
Copy link
Contributor

@maxj-oai maxj-oai commented Feb 20, 2026

  • keep the per-thread app-server listener alive when the last client unsubscribes or disconnects
  • preserve listener-side active turn history so running thread/resume can merge an in-progress turn snapshot after reconnect
  • add ThreadStateManager regressions for disconnect/unsubscribe retention and explicit thread teardown cleanup

Added unit tests, and I manually tested to confirm the fix

Keep the per-thread listener alive when the last client unsubscribes or
disconnects so listener-side active turn history survives reconnects and
running thread/resume can merge an in-progress turn snapshot.

Add targeted ThreadStateManager regressions for listener retention on
disconnect/unsubscribe and explicit teardown cleanup on thread removal.

Co-authored-by: Codex <noreply@openai.com>
@maxj-oai maxj-oai requested a review from celia-oai February 20, 2026 21:56
@maxj-oai maxj-oai marked this pull request as ready for review February 20, 2026 21:56
maxj-oai and others added 2 commits February 21, 2026 20:45
…stener

# Conflicts:
#	codex-rs/app-server/src/codex_message_processor.rs
Update the Bazel module lockfile after `rules_rs` crate extension facts drifted,
so `just bazel-lock-check` passes again.

Co-authored-by: Codex <noreply@openai.com>
@maxj-oai maxj-oai enabled auto-merge (squash) February 22, 2026 05:19
@maxj-oai maxj-oai merged commit 3761024 into main Feb 22, 2026
53 of 55 checks passed
@maxj-oai maxj-oai deleted the maxj/retain-thread-listener branch February 22, 2026 05:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants