Conversation
pakrym-oai
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex-corewas carrying the embedded system-skill sample assets (and abuild.rsthat walks those files to register rerun triggers). Those assets change infrequently, but any change undercodex-corestill ties them tocodex-core's build/cache lifecycle.This change moves the embedded system-skills packaging into a dedicated
codex-skillscrate so it can be cached independently. That reduces unnecessary invalidation/rebuild pressure oncodex-corewhen the skills bundle is the only thing that changes.What Changed
codex-rs/skillscrate (codex-skills) with:Cargo.tomlBUILD.bazelbuild.rsto track skill asset file changes for Cargo rebuildssrc/lib.rscontaining the embedded system-skills install/cache logic previously incodex-corecodex-rs/core/src/skills/assets/samplestocodex-rs/skills/src/assets/samples.codex-rs/core/Cargo.tomlto depend oncodex-skillsand removedcodex-core's directinclude_dirdependency.codex-core'sbuild.rs.codex-rs/core/src/skills/system.rsimplementation with a thin re-export wrapper to keep existingcodex-corecall sites unchanged.codex-rs/Cargo.toml,codex-rs/Cargo.lock) for the new crate.