Skip to content

feat(tui): support Alt-d delete-forward-word#12455

Merged
etraut-openai merged 1 commit intoopenai:mainfrom
dougEfresh:alt-d
Feb 22, 2026
Merged

feat(tui): support Alt-d delete-forward-word#12455
etraut-openai merged 1 commit intoopenai:mainfrom
dougEfresh:alt-d

Conversation

@dougEfresh
Copy link
Contributor

Alt-d should delete the next word. It didn’t. Now it does. Added a small test so it stays that way.

Details:
File updated: codex-rs/tui/src/bottom_pane/textarea.rs
Test added: delete_forward_word_alt_d — verifies Alt-d deletes the next word and keeps the cursor position correct.

Solves Issue #12453

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@dougEfresh
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 21, 2026
@etraut-openai
Copy link
Collaborator

We've updated our contribution guidelines to indicate that we're no longer accepting unsolicited code contributions. All code contributions are by invitation only. To read more about why we've taken this step, please refer to this announcement.

@dougEfresh
Copy link
Contributor Author

dougEfresh commented Feb 21, 2026

@etraut-openai Totally understood.

Just saying this is a 4 line change (excluding test) which addresses a mismatch between standard shell key bindings (i.e. readline) and codex TUI.

@etraut-openai
Copy link
Collaborator

@dougEfresh, yeah, this is a very contained change. Let me take a closer look at the PR.

@etraut-openai
Copy link
Collaborator

@codex review

@chatgpt-codex-connector
Copy link
Contributor

Security review completed. No security issues were found in this pull request.

View security finding report

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai
Copy link
Collaborator

Even simple keybinding changes like this can be trickier that one might think because of the wide variety of platforms and terminal emulators that we need to support, but this one looks fine to me.

Alt-d should delete the next word. It didn’t. Now it does.
Added a small test so it stays that way.

Details:
File updated: codex-rs/tui/src/bottom_pane/textarea.rs
Test added: delete_forward_word_alt_d — verifies Alt-d deletes the next word and keeps the cursor position correct.
@dougEfresh
Copy link
Contributor Author

Latest commit uses pretty_assertions::assert_eq and combined the Alt+Delete and Alt+d match arms into a single pattern

@etraut-openai etraut-openai merged commit 2ada9e1 into openai:main Feb 22, 2026
28 of 33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2026
@dougEfresh dougEfresh deleted the alt-d branch February 22, 2026 19:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants