feat(tui): support Alt-d delete-forward-word#12455
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
We've updated our contribution guidelines to indicate that we're no longer accepting unsolicited code contributions. All code contributions are by invitation only. To read more about why we've taken this step, please refer to this announcement. |
|
@etraut-openai Totally understood. Just saying this is a 4 line change (excluding test) which addresses a mismatch between standard shell key bindings (i.e. readline) and codex TUI. |
|
@dougEfresh, yeah, this is a very contained change. Let me take a closer look at the PR. |
|
@codex review |
|
Security review completed. No security issues were found in this pull request. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Even simple keybinding changes like this can be trickier that one might think because of the wide variety of platforms and terminal emulators that we need to support, but this one looks fine to me. |
Alt-d should delete the next word. It didn’t. Now it does. Added a small test so it stays that way. Details: File updated: codex-rs/tui/src/bottom_pane/textarea.rs Test added: delete_forward_word_alt_d — verifies Alt-d deletes the next word and keeps the cursor position correct.
|
Latest commit uses |
Alt-d should delete the next word. It didn’t. Now it does. Added a small test so it stays that way.
Details:
File updated: codex-rs/tui/src/bottom_pane/textarea.rs
Test added: delete_forward_word_alt_d — verifies Alt-d deletes the next word and keeps the cursor position correct.
Solves Issue #12453