fix(cli): run Windows updater via structured cmd invocation#12465
Closed
mihneaptu wants to merge 1 commit into
Closed
fix(cli): run Windows updater via structured cmd invocation#12465mihneaptu wants to merge 1 commit into
mihneaptu wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Collaborator
|
We've updated our contribution guidelines to indicate that we're no longer accepting unsolicited code contributions. All code contributions are by invitation only. To read more about why we've taken this step, please refer to this announcement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd /d /s /c <tool> <args>using structured process arguments.Why
The previous Windows path executed
cmd /Cwith a single pre-built command string. This is less robust than passing the tool and arguments as structured arguments, and can become brittle as command arguments evolve.Changes
run_update_actionto use a sharedupdate_command(...)builder.build_windows_update_command(...)helper that buildscmdarguments explicitly.windows_wrapped_update_command_includes_tool_and_args.Notes