Conversation
xl-openai
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Config.permissionsstoresapproval_policyandsandbox_policyasConstrained<...>, and that wrapper is part of the safety guarantee.TurnContextwas converting those fields to rawAskForApproval/SandboxPolicyvalues, so code operating onTurnContextno longer had a guarantee that the per-turn policies still honored the original constraints.This change preserves the
Constrainedwrappers inTurnContextso turn-level policy data carries the same guarantees asPermissions.Admittedly, there are still other types that maintain a reference to the raw value (such as
ExecApprovalRequest), but we'll defer changing that to subsequent PRs.What Changed
TurnContext.approval_policyandTurnContext.sandbox_policytoConstrained<...>.TurnContextconstruction to clone the constrained values from session/config state instead of stripping them to raw values..value()/.get()only where raw policy values are required (tool orchestration, safety checks, MCP/network checks, and context serialization/diffing)..set(...)on the constrained wrappers.Verification
cargo check -p codex-corecargo test -p codex-core(local run failed only in unrelatedskills::loadertests due extra user-scoped skills present in this environment; touchedcodex,unified_exec,multi_agents, andjs_repltests passed)