Revert "Revert "Route inbound realtime text into turn start or steer""#12480
Merged
aibrahim-oai merged 15 commits intomainfrom Feb 22, 2026
Merged
Conversation
aibrahim-oai
force-pushed
the
revert-12479-revert-12469-realtime-inbound-text-start-or-steer
branch
from
960f18f to
89136de
Compare
Wait for the gated first streaming SSE response and the steer follow-up response to complete before asserting TurnComplete in inbound_realtime_text_steers_active_turn. This removes a Windows-specific event ordering race without increasing timeouts. Co-authored-by: Codex <noreply@openai.com>
Remove the temporary streaming SSE helper API changes and unrelated test updates. Keep the runtime ordering fix and the targeted realtime steer test sequencing only.\n\nCo-authored-by: Codex <noreply@openai.com>
Fast-path inbound realtime text steering into the active turn before mirroring the realtime event, avoiding a Windows-only deadlock in the steer test. Also make realtime websocket fixtures tolerate optional prewarm connections in the realtime conversation tests.\n\nCo-authored-by: Codex <noreply@openai.com>
This reverts commit aa6cc61.
Add targeted eprintln! tracing across realtime conversation runtime, websocket/SSE test helpers, and realtime conversation tests to capture Windows CI ordering and connection-slot behavior.\n\nCo-authored-by: Codex <noreply@openai.com>
Update streaming_sse unit tests for the debug-only helper signature changes so Windows CI can reach the realtime conversation failures and emit instrumentation logs.\n\nCo-authored-by: Codex <noreply@openai.com>
Windows debug logs show the steer test websocket script's second request slot is consumed by the mirrored assistant message ("first turn") before the audio-triggered inbound steer event. Add an empty intermediate scripted request so the steer event is delivered on the following request.\n\nCo-authored-by: Codex <noreply@openai.com>
This reverts commit 9949287.
This reverts commit 6893924.
…ext-start-or-steer
aibrahim-oai
deleted the
revert-12479-revert-12469-realtime-inbound-text-start-or-steer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With working tests this time