feat: keep dead agents in the agent picker

[jif-oai]

No description provided.

[jif-oai]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

codex/codex-rs/tui/src/app.rs

Lines 996 to 1002 in 3c942c3

	let Some((receiver, snapshot)) = self.activate_thread_for_replay(thread_id).await else {
	self.chat_widget
	.add_error_message(format!("Agent thread {thread_id} is already active."));
	if let Some(previous_thread_id) = previous_thread_id {
	self.activate_thread_channel(previous_thread_id).await;
	}
	return Ok(());

Allow reopening closed agent threads

select_agent_thread treats activate_thread_for_replay(..) returning None as “already active”. For closed threads this happens after one replay: drain_active_thread_events consumes a disconnected receiver and clears it, so subsequent selections of the same dead agent always fail with an incorrect error. This breaks the new picker behavior because dead agents remain listed but cannot be reopened.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Security review completed. No security issues were found in this pull request.

View security finding report

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

• You comment "@codex security review"
• A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.