Skip to content

feat: add search term to thread list#12578

Merged
jif-oai merged 10 commits intomainfrom
jif/search-term
Feb 25, 2026
Merged

feat: add search term to thread list#12578
jif-oai merged 10 commits intomainfrom
jif/search-term

Conversation

@jif-oai
Copy link
Collaborator

@jif-oai jif-oai commented Feb 23, 2026

Add searchTerm to thread/list that will search for a match in the titles (the condition being searchTerm $$\in$$ title)

@jif-oai
Copy link
Collaborator Author

jif-oai commented Feb 25, 2026

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

if state_db_ctx.is_none() {
// Keep legacy behavior when SQLite is unavailable: return filesystem results
// at the requested page size.
return Ok(truncate_fs_page(fs_page, page_size, sort_key));
}

P1 Badge Apply searchTerm filter on filesystem fallback

searchTerm is only applied via SQLite. If SQLite is unavailable/backfill-incomplete, or DB listing fails, this path returns truncate_fs_page(...) directly and skips title filtering. thread/list can therefore return non-matching threads even when searchTerm is set, making API behavior depend on DB state instead of request params.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit f46b767 into main Feb 25, 2026
33 checks passed
@jif-oai jif-oai deleted the jif/search-term branch February 25, 2026 09:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants