Honor project_root_markers when discovering AGENTS.md#12639
Merged
etraut-openai merged 1 commit intomainfrom Feb 24, 2026
Merged
Honor project_root_markers when discovering AGENTS.md#12639etraut-openai merged 1 commit intomainfrom
project_root_markers when discovering AGENTS.md#12639etraut-openai merged 1 commit intomainfrom
Conversation
project_root_markers when discovering AGENTS.md
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dylan-hurd-oai
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12128
The docs indicates that
project_root_markersare used to discover the project root for local config as well asAGENTS.md. It looks like it was never wired up to support the latter.Summary
project_root_markers(or defaults) instead of assuming the Git root, while honoring CLI overrides and handling malformed configs.gitare respected