chore: migrate additional permissions to PermissionProfile#12731
Merged
chore: migrate additional permissions to PermissionProfile#12731
Conversation
celia-oai
force-pushed
the
dev/cc/new-approval-field
branch
3 times, most recently
from
5de07fc to
3838bcb
Compare
celia-oai
force-pushed
the
dev/cc/new-approval-field
branch
from
3838bcb to
60b5ac4
Compare
celia-oai
changed the title
dylan-hurd-oai
approved these changes
Feb 25, 2026
Collaborator
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
Couple build errors to fix but this looks directionally reasonable to me
celia-oai
force-pushed
the
dev/cc/new-approval-field
branch
2 times, most recently
from
bce8ac2 to
20c9720
Compare
celia-oai
force-pushed
the
dev/cc/new-approval-field
branch
from
20c9720 to
05cc062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the old
additional_permissions.fs_read/fs_writeshape with a sharedPermissionProfilemodel and wires it through the command approval, sandboxing, protocol, and TUI layers. The schema is adopted from the
SkillManifestPermissions, which is also refactored to use this unified struct. This helps us easily expose permission profiles in app server/core as a follow-up.