Revert "fix(bazel): replace askama templates with include_str! in memories"#12795
Merged
Revert "fix(bazel): replace askama templates with include_str! in memories"#12795
Conversation
…ories (#…" This reverts commit fe7054a.
| "//codex-rs:node-version.txt", | ||
| ], | ||
| rustc_env = { | ||
| # Askama resolves template paths relative to CARGO_MANIFEST_DIR. In |
Contributor
There was a problem hiding this comment.
interseting, I've seen some weirdness/confusion in crate around when CARGO_MANIFEST_DIR is resolved (build time of dep vs build time of consuming crate) so I wonder if it's related? But anyway if this compiles I guess that works as well :) Just a bit worried about the blast radius here since core is so big...
zbarsky-openai
approved these changes
Feb 25, 2026
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #11778