feat: add local date/timezone to turn environment context#12947
Merged
feat: add local date/timezone to turn environment context#12947
Conversation
7c9f188 to
42d1281
Compare
pakrym-oai
reviewed
Feb 26, 2026
| icu_provider = { version = "2.1", features = ["sync"] } | ||
| ignore = "0.4.23" | ||
| image = { version = "^0.25.9", default-features = false } | ||
| iana-time-zone = "0.1.64" |
Collaborator
Author
There was a problem hiding this comment.
codex says:
• No. In this workspace it is not a huge dependency.
iana-time-zone = "0.1.64" is a small platform abstraction crate for getting the local IANA time zone. Also, that manifest entry is a semver range, so the lockfile currently resolves it to 0.1.65, not exactly 0.1.64.
What matters here:
- On this macOS workspace, cargo tree -p iana-time-zone shows it resolves to just core-foundation-sys.
- The lockfile lists Android/wasm/Windows helpers too, but those are target-specific, not all compiled on this platform.
- It is already in the graph via chrono, so in this repo the incremental cost is effectively negligible.
charley-oai
reviewed
Feb 26, 2026
d1c1df2 to
f030156
Compare
charley-oai
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes the session's local date and timezone in the model-visible environment context and persists that data in
TurnContextItem.What changed
test
built a local build and saw it in the rollout file: