tui: fix codex header vertical shift at startup#12956
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
rhan-oai
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/tui/src/chatwidget.rs
Lines 6915 to 6917 in 7311e07
Bump revision after replacing placeholder session header
When merged_header is true, apply_session_info_cell replaces active_cell with the real session info but no longer flushes or increments active_cell_revision. active_cell_transcript_key() uses that revision for live-tail cache invalidation, so an already-open transcript overlay (Ctrl+T) can keep rendering the stale placeholder header until another active-cell mutation happens.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
rhan-oai
force-pushed
the
codex/loading
branch
from
7311e07 to
c800db5
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b560a46be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.pending_shutdown_exit_thread_id = None; | ||
| } | ||
| if let EventMsg::SessionConfigured(session) = &event.msg | ||
| && let Some(first_cell) = self.transcript_cells.first_mut() |
There was a problem hiding this comment.
handle_active_thread_event only replaces transcript_cells.first_mut() when a SessionConfigured arrives. But start_fresh_session_with_summary_hint appends a new placeholder header via insert_startup_header even when prior transcript cells exist (e.g. /new). In that case the placeholder is not index 0, so it never gets replaced and the UI can keep showing loading indefinitely.
Useful? React with 👍 / 👎.
1 participant
Remove redundant flush_active_cell, logically handled by add_box_history.
Before
Screen.Recording.2026-02-23.at.7.39.10.PM.mov
After
codex.loading.mov