core: reuse parent shell snapshot for thread-spawn subagents#13052
Merged
daveaitel-openai merged 1 commit intomainfrom Mar 2, 2026
Merged
core: reuse parent shell snapshot for thread-spawn subagents#13052daveaitel-openai merged 1 commit intomainfrom
daveaitel-openai merged 1 commit intomainfrom
Conversation
Pass the parent session's shell snapshot into spawned/resumed/forked thread-spawn subagents so they bootstrap from inherited shell state instead of creating a fresh snapshot. Also skip shell snapshot refresh on cwd changes for thread-spawn subagents, so inherited snapshots are not replaced during child-session updates. Co-authored-by: Codex <noreply@openai.com>
jif-oai
reviewed
Feb 28, 2026
| return; | ||
| } | ||
|
|
||
| if matches!( |
Collaborator
There was a problem hiding this comment.
This means we never refresh the shell snapshot. But what if a sub-agent change cwd for example? In this case we need to be able to refresh it
Contributor
Author
There was a problem hiding this comment.
This is a really good point and I'm not sure how to address it yet.
| agent_control: AgentControl, | ||
| session_source: SessionSource, | ||
| persist_extended_history: bool, | ||
| inherited_shell_snapshot: Option<Arc<ShellSnapshot>>, |
Collaborator
There was a problem hiding this comment.
In the end we will have to pack all those things in a struct instead of having to wire those agrs everywhere but we can do as a follow-up
Contributor
Author
There was a problem hiding this comment.
100% agree.
jif-oai
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionSource::SubAgent(SubAgentSource::ThreadSpawn { .. })sessionsAgentControl -> ThreadManager -> Codex::spawn -> SessionConfigurationWhy
Validation
just fmt(incodex-rs)cargo test -p codex-core --no-runcargo test -p codex-core spawn_agent -- --nocapturecargo test -p codex-core --test all suite::agent_jobs::spawn_agents_on_csv_runs_and_exportsNotes
cargo test -p codex-core --test allwas left running separately for broader verification