app-server: Silence thread status changes caused by thread being created#13079
Merged
euroelessar merged 2 commits intomainfrom Mar 3, 2026
Merged
app-server: Silence thread status changes caused by thread being created#13079euroelessar merged 2 commits intomainfrom
euroelessar merged 2 commits intomainfrom
Conversation
euroelessar
force-pushed
the
ruslan/no-status-changed-before-thread-start
branch
from
ad8b616 to
a62dd55
Compare
maxj-oai
approved these changes
Mar 3, 2026
| .await; | ||
| } | ||
|
|
||
| async fn upsert_thread_with_notification(&self, thread: Thread, emit_notification: bool) { |
Contributor
There was a problem hiding this comment.
nit: suggest inlining this into the 2 callers as it's not adding much
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we emit
thread/status/changedwithIdlestatus right before sendingthread/startedevent (which also hasIdlestatus in it).It feels that there is no point in that as client has no way to know prior state of the thread as it didn't exist yet, so silence these kinds of notifications.