Add role-specific subagent nickname overrides#13218
Merged
gabec-openai merged 3 commits intomainfrom Mar 4, 2026
Merged
Conversation
jif-oai
reviewed
Mar 2, 2026
gabec-openai
force-pushed
the
codex/nickname-overrides
branch
from
a9f7b3d to
f3d29fe
Compare
Contributor
Author
|
@jif-oai addressed all your comments, thanks! |
jif-oai
approved these changes
Mar 4, 2026
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
LGTM once my last comment is processed
| } | ||
| } | ||
|
|
||
| fn normalize_agent_role_nickname_candidates( |
Collaborator
There was a problem hiding this comment.
nit: can we do stronger normalization? I would like prevent user from inserting <, &, ... to prevent XML collision or bad interpretation from the model
Same thing for non-UTF-8
Basically we could accept only alphanum and , -, _ or something like this
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
gabec-openai
force-pushed
the
codex/nickname-overrides
branch
from
2db9cfb to
1fed499
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nickname_candidatesto agent role configTesting
just fmtjust write-config-schemajust fix -p codex-corecargo test -p codex-corecargo test