Conversation
aibrahim-oai
commented
Mar 2, 2026
aibrahim-oai
commented
- migrate the realtime websocket transport to the new session and handoff flow
- make the realtime model configurable in config.toml and use API-key auth for the websocket
- migrate the realtime websocket transport to the new session and handoff flow - make the realtime model configurable via config.toml and use API-key auth for the websocket Co-authored-by: Codex <noreply@openai.com>
- group handoff output sender and active handoff id into a dedicated state object - centralize handoff output enqueue and active handoff lookup behavior Co-authored-by: Codex <noreply@openai.com>
|
@codex review this |
- log in with an API key before starting realtime in app-server realtime tests - keep the test flow aligned with the new realtime websocket auth requirement Co-authored-by: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75c4cd839d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Keep handoff targeting active across multiple handoff append sends and clear it when the local task emits TurnComplete instead of on conversation.item.done. Co-authored-by: Codex <noreply@openai.com>
Add an integration test that proves handoff append targeting persists after conversation.item.done and continues until the delegated turn completes. Co-authored-by: Codex <noreply@openai.com>
Fix clippy::single_match in realtime handoff event handling. Co-authored-by: Codex <noreply@openai.com>
|
@codex review this |
Read active handoff id when sending realtime handoff output and keep queue payload to text-only.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6476bd42f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !matches!(msg, EventMsg::TurnComplete(_)) { | ||
| return; |
There was a problem hiding this comment.
maybe_clear_realtime_handoff_for_event only clears state on EventMsg::TurnComplete. If a delegated turn is interrupted/errors (TurnAborted, stream failure, etc.), active_handoff_id remains set. Later assistant output still passes maybe_mirror_event_text_to_realtime and gets sent to conversation.handoff.append, misrouting unrelated text to a stale handoff.
Useful? React with 👍 / 👎.
| pub async fn send_audio_frame(&self, frame: RealtimeAudioFrame) -> Result<(), ApiError> { | ||
| self.send_json(RealtimeOutboundMessage::InputAudioDelta { | ||
| delta: frame.data, | ||
| sample_rate: frame.sample_rate, | ||
| num_channels: frame.num_channels, | ||
| samples_per_channel: frame.samples_per_channel, | ||
| }) | ||
| .await | ||
| self.send_json(RealtimeOutboundMessage::InputAudioBufferAppend { audio: frame.data }) |
There was a problem hiding this comment.
send_audio_frame now transmits only frame.data and drops sample_rate/num_channels, while session.update fixes input format to 24k mono. Callers can still submit arbitrary RealtimeAudioFrame formats, so non-24k/non-mono audio will be interpreted with the wrong format, causing distorted or incorrect transcription/audio behavior.
Useful? React with 👍 / 👎.
Replace the unused handoff_id guard in send_output with an explicit active-state check.
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
2 participants
