feat(app-server-test-client): support tracing#13286
Merged
Conversation
2e56493 to
04ad015
Compare
04ad015 to
5f1a7a5
Compare
5f1a7a5 to
4d7d376
Compare
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/app-server-test-client/src/lib.rs
Lines 703 to 715 in 4d7d376
The commit message says each run should print a Datadog trace link, but thread_resume_follow (and similarly watch) still instantiate CodexClient directly and return stream_notifications_forever() without calling print_trace_summary(). If these commands end due disconnect/error, no trace URL is emitted.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
celia-oai
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds tracing support to the
app-server-test-clientso requests it sends to app-server carry W3C trace context, and each run prints an easy-to-follow trace link at the end. Depends on #13285Example:
What changed
traceparentmetadata to outgoing JSON-RPC requests from the test clientWhy
The test client is useful for reproducing app-server behavior locally, but it was hard to connect a local run to backend traces. With this change, local debugging gets a lot easier: you can run the client, reproduce the issue, and immediately inspect the corresponding trace.