Skip to content

[bazel] Bump rules_rs and llvm#13366

Merged
zbarsky-openai merged 1 commit intomainfrom
zbarsky/rules-rs
Mar 4, 2026
Merged

[bazel] Bump rules_rs and llvm#13366
zbarsky-openai merged 1 commit intomainfrom
zbarsky/rules-rs

Conversation

@zbarsky-openai
Copy link
Contributor

@zbarsky-openai zbarsky-openai commented Mar 3, 2026

With upstream fixes we can simplify some things:

  • More careful treatment of deps in macro allows to drop integration_deps_extra hack
  • previous libclang.so was not hermetic, specify more properly following rules_rs recommendation for the override
  • rework all_crate_deps handling to account for rules-rs no longer wrapping the dep lists in rust_deps rule (which broke CcInfo propagation).
  • No need for special proc-macro handling as rules_rs transparently handles it now
  • windows import annotations are handled transparently now
  • switch to official rules_rs release instead of side branch

@zbarsky-openai zbarsky-openai enabled auto-merge (squash) March 3, 2026 16:44
@zbarsky-openai zbarsky-openai force-pushed the zbarsky/rules-rs branch 12 times, most recently from c3a345b to 8b0f553 Compare March 3, 2026 21:00
Copy link
Collaborator

@bolinfest bolinfest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks: this certainly feels simpler and I'm excited to try this out!

@zbarsky-openai zbarsky-openai merged commit 2d8c157 into main Mar 4, 2026
34 of 36 checks passed
@zbarsky-openai zbarsky-openai deleted the zbarsky/rules-rs branch March 4, 2026 01:59
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants